Thread (4 messages) flat view 4 messages, 3 authors, 2017-03-08

Re: [PATCH] powerpc: Sort the selects under CONFIG_PPC

From: Stephen Rothwell <hidden>
Date: 2017-03-06 20:42:15

Hi Michael,

On Mon,  6 Mar 2017 23:05:17 +1100 Michael Ellerman [off-list ref] wrote:
We have a big list of selects under CONFIG_PPC, and currently they're
completely unsorted. This means people tend to add new selects at the
bottom of the list, and so two commits which both add a new select will
often conflict.

Instead sort it alphabetically. This is nicer in and of itself, but also
means two commits that add a new select will have a greater chance of
not conflicting.

Add a note at the top and bottom asking people to keep it sorted.

And while we're here pad out the 'if' expressions to make them stand
out.

Suggested-by: Stephen Rothwell <redacted>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Looks good.
+	select ARCH_USE_CMPXCHG_LOCKREF		if PPC64
Why not just move these "if PPC64" selects to "config PPC64" in
arch/powerpc/platforms/Kconfig.cputype?  Secondary question: why not
move "config PPC64" to this file?
+	select GENERIC_ATOMIC64			if PPC32
Similarly ...

-- 
Cheers,
Stephen Rothwell
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help