[PATCH 03/18] pstore: Avoid race in module unloading
From: Kees Cook <hidden>
Date: 2017-03-06 22:24:59
Also in:
linux-acpi, linux-efi, lkml
Subsystem:
filesystems (vfs and infrastructure), pstore filesystem, the rest · Maintainers:
Alexander Viro, Christian Brauner, Kees Cook, Linus Torvalds
Technically, it might be possible for struct pstore_info to go out of scope after the module_put(), so report the backend name first. Signed-off-by: Kees Cook <redacted> --- fs/pstore/platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
index 074fe85a2078..d69ef8a840b9 100644
--- a/fs/pstore/platform.c
+++ b/fs/pstore/platform.c@@ -722,10 +722,10 @@ int pstore_register(struct pstore_info *psi) */ backend = psi->name; - module_put(owner); - pr_info("Registered %s as persistent store backend\n", psi->name); + module_put(owner); + return 0; } EXPORT_SYMBOL_GPL(pstore_register);
--
2.7.4