RE: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

From
David Laight <hidden>
Date
2017-03-06 14:59:59
Also in
lkml
Reply to
Peter Zijlstra, 2017-03-06
From: Peter Zijlstra
Sent: 06 March 2017 11:22
To: Madhavan Srinivasan
Cc: Wang Nan; Alexander Shishkin; <redacted>; Arnaldo C=
arvalho de Melo; Alexei
Starovoitov; Ingo Molnar; Stephane Eranian; Sukadev Bhattiprolu; linuxppc=
-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of pe=
rf_mem_data_src
=20
On Mon, Mar 06, 2017 at 04:13:08PM +0530, Madhavan Srinivasan wrote:
quoted
From: Sukadev Bhattiprolu <redacted>

perf_mem_data_src is an union that is initialized via the ->val field
and accessed via the bitmap fields. For this to work on big endian
platforms, we also need a big-endian represenation of perf_mem_data_src=
.
=20
Doesn't this break interpreting the data on a different endian machine?
Best to avoid bitfields if you ever care about the bit order.

	David
Thread (21 messages) 21 messages, 5 authors, last reply 2017-03-16
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help