Re: [PATCH 1/3] futex: remove duplicated code
From: Chris Metcalf <hidden>
Date: 2017-03-03 15:08:47
Also in:
linux-alpha, linux-arch, linux-arm-kernel, linux-mips, linux-sh, lkml, sparclinux
On 3/3/2017 7:27 AM, Jiri Slaby wrote:
There is code duplicated over all architecture's headers for
futex_atomic_op_inuser. Namely op decoding, access_ok check for uaddr,
and comparison of the result.
Remove this duplication and leave up to the arches only the needed
assembly which is now in arch_futex_atomic_op_inuser.
Note that s390 removed access_ok check in d12a29703 ("s390/uaccess:
remove pointless access_ok() checks") as access_ok there returns true.
We introduce it back to the helper for the sake of simplicity (it gets
optimized away anyway).
Signed-off-by: Jiri Slaby<redacted>Acked-by: Chris Metcalf <redacted> [for tile] -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com