Re: [v7,2/4] powerpc/pseries: Revert 'Auto-online hotplugged memory'
From: Michael Ellerman <hidden>
Date: 2017-02-27 10:11:04
On Wed, 2017-02-15 at 18:45:30 UTC, Nathan Fontenot wrote:
Revert the patch patch to auto-online hotplugged memory, commit id ec999072442a. Using the auto-online acpability does online added memory but does not update the associated device struct to indicate that the memory is online. The result of this is that memoryXX/online file in sysfs still reports the memory as being offline. Additionally, not updating the device struct to indicate the memory is online will cause the pseries memory DLPAR code to fail when trying to remove a LMB that was previously removed and added back. This happens when validating that the LMB is removable. Looking further into the auto-online memory, it seems that this capability is meant more for something like a balloon driver rather than general memory hotplug. This patch reverts to the previous behavior of calling device_online() to online the LMB when it is DLPAR added and moves the lmb_to_memblock() routine out of CONFIG_MEMORY_HOTREMOVE now that we call it for add. Signed-off-by: Nathan Fontenot <redacted>
Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/943db62c316c578f8e2cc6fb81a5f6 cheers