Re: [PATCH] powerpc: Fix inconsistent of_node_to_nid EXPORT_SYMBOL handling
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2017-02-09 12:18:57
Shailendra Singh [off-list ref] writes:
The generic implementation of of_node_to_nid is EXPORT_SYMBOL.
True. Added in 298535c00a2c, in April 2016.
The powerpc implementation added by following commit is EXPORT_SYMBOL_GPL.
commit 953039c8df7b ("[PATCH] powerpc: Allow devices to register with numa
topology")Which was merged in May 2006. So the powerpc version has almost 10 years precedence.
This creates an inconsistency for of_node_to_nid callers across architectures. Update the powerpc implementation to be exported consistently with the generic implementation.
But I guess it's a pretty boring API. So I'll merge this unless anyone else objects. cheers
quoted hunk ↗ jump to hunk
Signed-off-by: Shailendra Singh <redacted> Reviewed-by: Andy Ritger <redacted> --- arch/powerpc/mm/numa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index b1099cb2f393..8aa4ca3c84c9 100644 --- a/arch/powerpc/mm/numa.c +++ b/arch/powerpc/mm/numa.c@@ -290,7 +290,7 @@ int of_node_to_nid(struct device_node *device) return nid; } -EXPORT_SYMBOL_GPL(of_node_to_nid); +EXPORT_SYMBOL(of_node_to_nid); static int __init find_min_common_depth(void) {-- 2.4.11