Thread (4 messages) 4 messages, 3 authors, 2017-02-27

Re: [PATCH] powerpc: Remove leftover cputime_to_nsecs call causing build error

From: Frederic Weisbecker <hidden>
Date: 2017-02-23 04:02:29
Also in: lkml

On Thu, Feb 23, 2017 at 08:34:15AM +1100, Michael Ellerman wrote:
Frederic Weisbecker [off-list ref] writes:
quoted
This type conversion is a leftover that got ignored during the kcpustat
conversion to nanosecs, resulting in build breakage with config having
CONFIG_NO_HZ_FULL=y.

	arch/powerpc/kernel/time.c: In function 'running_clock':
	arch/powerpc/kernel/time.c:712:2: error: implicit declaration of function 'cputime_to_nsecs' [-Werror=implicit-function-declaration]
	  return local_clock() - cputime_to_nsecs(kcpustat_this_cpu->cpustat[CPUTIME_STEAL]);

All we need is to remove it.

Reported-by: Abdul Haleem <redacted>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <redacted>
Cc: Oliver O'Halloran <oohall@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Frederic Weisbecker <redacted>
LGTM.

Acked-by: Michael Ellerman <mpe@ellerman.id.au>


Are you going to send this to Linus, or should I?
I would prefer you send it to Linus if you don't mind.

The fate of a powerpc patch sent by me directly to Linus is
anything but predictable :o)

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help