Thread (14 messages) flat view 14 messages, 3 authors, 2017-01-26

Re: [PATCH net 1/5] ibmvnic: harden interrupt handler

From: David Miller <davem@davemloft.net>
Date: 2017-01-26 04:04:26
Also in: netdev

From: Thomas Falcon <redacted>
Date: Wed, 25 Jan 2017 15:02:19 -0600
Move most interrupt handler processing into a tasklet, and
introduce a delay after re-enabling interrupts to fix timing
issues encountered in hardware testing.

Signed-off-by: Thomas Falcon <redacted>
I don't think you have any idea what the real problem is.  This looks
like a hack, at best.  Next patch you'll increase the delay to "20",
right?  And if that doesn't work you'll try "40".

Or if you do know the reason, you need to explain it in detail in this
commit message so that we can properly evaluate this patch.

Furthermore, if you're going to move all of your packet processing
into software interrupt context, you might as well use NAPI polling
which is a purposefully built piece of infrastructure for doing
exactly this.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help