Thread (3 messages) 3 messages, 3 authors, 2017-01-05

Re: [PATCH] cpufreq: Remove CONFIG_CPU_FREQ_STAT_DETAILS config option

flat view

From: Chanwoo Choi <cw00.choi@samsung.com>
Date: 2017-01-05 10:22:47
Also in: linux-arm-kernel, linux-mips, linux-pm, linux-renesas-soc, linux-samsung-soc, linux-sh, lkml

Hi Viresh,

On 2017년 01월 05일 17:27, Viresh Kumar wrote:
This doesn't have any benefit apart from saving a small amount of memory
when it is disabled. The ifdef hackery in the code makes it dirty
unnecessarily.

Clean it up by removing the Kconfig option completely. Few defconfigs
are also updated and CONFIG_CPU_FREQ_STAT_DETAILS is replaced with
CONFIG_CPU_FREQ_STAT now in them, as users wanted stats to be enabled.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 arch/arm/configs/exynos_defconfig         |  2 +-
 arch/arm/configs/multi_v5_defconfig       |  2 +-
 arch/arm/configs/multi_v7_defconfig       |  2 +-
 arch/arm/configs/mvebu_v5_defconfig       |  2 +-
 arch/arm/configs/pxa_defconfig            |  2 +-
 arch/arm/configs/shmobile_defconfig       |  2 +-
 arch/mips/configs/lemote2f_defconfig      |  1 -
 arch/powerpc/configs/ppc6xx_defconfig     |  1 -
 arch/sh/configs/sh7785lcr_32bit_defconfig |  2 +-
 drivers/cpufreq/Kconfig                   |  8 --------
 drivers/cpufreq/cpufreq_stats.c           | 14 --------------
 11 files changed, 7 insertions(+), 31 deletions(-)

I agree. Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

[snip]

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help