Re: [PATCH V3 3/4] arch/powerpc: Implement Optprobes

On 2016/12/25 11:54AM, Masami Hiramatsu wrote:

On Mon, 19 Dec 2016 18:48:24 +0530
Anju T Sudhakar [off-list ref] wrote:

quoted

Detour buffer contains instructions to create an in memory pt_regs.
After the execution of the pre-handler, a call is made for instruction emulation.
The NIP is determined in advanced through dummy instruction emulation and a branch
instruction is created to the NIP at the end of the trampoline.

Instruction slot for detour buffer is allocated from the reserved area.
For the time being, 64KB is reserved in memory for this purpose.

Instructions which can be emulated using analyse_instr() are suppliants
for optimization. Before optimization ensure that the address range
between the detour buffer allocated and the instruction being probed
is within ± 32MB.

Signed-off-by: Anju T Sudhakar <redacted>
Signed-off-by: Naveen N. Rao <redacted>

Looks good to me :)

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thanks, Masami!

Ben/Michael,
Can you please take a look and let us know your thoughts on this?

- Naveen