Re: powerpc/eeh: fix deadlock when PE frozen state can't be cleared
From: Michael Ellerman <hidden>
Date: 2016-12-03 11:31:13
On Thu, 2016-12-01 at 00:23:05 UTC, Andrew Donnellan wrote:
In eeh_reset_device(), we take the pci_rescan_remove_lock immediately after
after we call eeh_reset_pe() to reset the PCI controller. We then call
eeh_clear_pe_frozen_state(), which can return an error. In this case, we
bail out of eeh_reset_device() without calling pci_unlock_rescan_remove().
Add a call to pci_unlock_rescan_remove() in the eeh_clear_pe_frozen_state()
error path so that we don't cause a deadlock later on.
Reported-by: Pradipta Ghosh <redacted>
Fixes: 78954700631f ("powerpc/eeh: Avoid I/O access during PE reset")
Cc: stable@vger.kernel.org
Signed-off-by: Andrew Donnellan <redacted>
Acked-by: Russell Currey <redacted>Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/409bf7f8a02ef88db5a0f2cdcf9489 cheers