RE: [v2, 2/3] powerpc/fsl/dts: add QMan and BMan portal nodes on t1024

From: Scott Wood [mailto:oss@buserror.net]
Sent: Wednesday, December 07, 2016 2:59 AM
=20
On Tue, Dec 06, 2016 at 03:13:38PM +0200, Madalin Bucur wrote:

quoted

Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
---
 arch/powerpc/boot/dts/fsl/t1024qds.dts | 29

+++++++++++++++++++++++++++++

quoted

 arch/powerpc/boot/dts/fsl/t1024rdb.dts | 33

+++++++++++++++++++++++++++++++++

quoted

 2 files changed, 62 insertions(+)

=20
So, in patch 1/3 you add qman and bman nodes to t1023si-post.dtsi and
call it "add QMan and BMan portal nodes on t1023rdb" as if it were
board-specific (the only board-specific part is the reserved-memory
nodes, not the portals).
=20
Then, in this patch you only touch board-specific files, and label it
"add QMan and BMan portal nodes on t1024"...

That needs fixing...

quoted

diff --git a/arch/powerpc/boot/dts/fsl/t1024rdb.dts

b/arch/powerpc/boot/dts/fsl/t1024rdb.dts

quoted

index 302cdd2..73a6453 100644

--- a/arch/powerpc/boot/dts/fsl/t1024rdb.dts
+++ b/arch/powerpc/boot/dts/fsl/t1024rdb.dts

@@ -41,6 +41,31 @@
 	#size-cells =3D <2>;
 	interrupt-parent =3D <&mpic>;

+	aliases {
+		sg_2500_aqr105_phy4 =3D &sg_2500_aqr105_phy4;
+	};

=20
What does this have to do with the qman and bman portal nodes?  Why is
this alias needed?
=20
-Scott

It's needed by u-boot, should be a separate patch.
I'll resend.

Madalin