Re: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode

From
Andreas Schwab <hidden>
Date
2016-12-28 16:52:52
Also in
alsa-devel, lkml
On Dez 28 2016, Timur Tabi [off-list ref] wrote:
Andreas Schwab wrote:
quoted
quoted
quoted
+	return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) ==
+		SND_SOC_DAIFMT_AC97;
This is never true.
I think the right parenthesis should be at the end of the expression.
That would still test the wrong bitfield.

And all that is obsolete anyway since commit 5b64c173cd (of Sep 2015).

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
Thread (1 message) 1 message, 1 author, last reply 2016-12-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help