Thread (8 messages) 8 messages, 2 authors, 2016-12-19

RE: [PATCH net v2 2/5] powerpc: remove fsl,fman from of_device_ids[]

From: Madalin-Cristian Bucur <madalin.bucur@nxp.com>
Date: 2016-12-19 16:40:13
Also in: lkml, netdev

From: David Miller [mailto:davem@davemloft.net]
Sent: Monday, December 19, 2016 5:37 PM
=20
From: Madalin Bucur <madalin.bucur@nxp.com>
Date: Mon, 19 Dec 2016 11:22:20 +0200
=20
quoted
The fsl/fman drivers will use of_platform_populate() on all
supported platforms.

Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
=20
It seems that this creates a failure point between patches #2 and
#3.  If the cases handled by this "fsl,fman" entry are only afterwards
covered by the of_platform_populate() code added in patch #3 then you
cannot split these two changes up like this.
=20
The two changes must be done at the same time, otherwise probing will
fail for some people between patches #2 and #3.
You are right, that will happen. I was not convinced these need to be
merged due to the different places they touch. I'll send a v3.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help