Re: [PATCH 03/11] powerpc/kvm: Gather HPT related variables into sub-structure
From: Thomas Huth <hidden>
Date: 2016-12-16 09:24:36
Also in:
kvm, lkml
On 15.12.2016 06:53, David Gibson wrote:
quoted hunk ↗ jump to hunk
Currently, the powerpc kvm_arch structure contains a number of variables tracking the state of the guest's hashed page table (HPT) in KVM HV. This patch gathers them all together into a single kvm_hpt_info substructure. This makes life more convenient for the upcoming HPT resizing implementation. Signed-off-by: David Gibson <redacted> --- arch/powerpc/include/asm/kvm_host.h | 16 ++++--- arch/powerpc/kvm/book3s_64_mmu_hv.c | 90 ++++++++++++++++++------------------- arch/powerpc/kvm/book3s_hv.c | 2 +- arch/powerpc/kvm/book3s_hv_rm_mmu.c | 62 ++++++++++++------------- 4 files changed, 87 insertions(+), 83 deletions(-)diff --git a/arch/powerpc/include/asm/kvm_host.h b/arch/powerpc/include/asm/kvm_host.h index e59b172..2673271 100644 --- a/arch/powerpc/include/asm/kvm_host.h +++ b/arch/powerpc/include/asm/kvm_host.h@@ -241,12 +241,20 @@ struct kvm_arch_memory_slot { #endif /* CONFIG_KVM_BOOK3S_HV_POSSIBLE */ }; +struct kvm_hpt_info { + unsigned long virt; + struct revmap_entry *rev; + unsigned long npte; + unsigned long mask; + u32 order; + int cma; +};
While you're at it, it would be really great if you could add a comment at the end of each line with a short description of what the variables are about. E.g. if I just read "virt" and do not have much clue of the code yet, I have a hard time to figure out what this means... Thomas