Re: [PATCH] of/irq: improve error message on irq discovery process failure

On 11/11/2016 05:12 PM, Benjamin Herrenschmidt wrote:

On Fri, 2016-11-11 at 16:32 +0000, Mark Rutland wrote:

quoted

On Fri, Nov 11, 2016 at 08:30:43AM +1100, Benjamin Herrenschmidt
wrote:

quoted

On Wed, 2016-11-09 at 19:04 +0000, Mark Rutland wrote:

quoted

If we don't have an interrupt-map on a PCI controller, why don't
we
instead log a message regarding that being missing, and give up
early?

Why ? It's legit to not support LSIs.

Sure; I had envisioned a message like:

	pr_info("%s: no interrupt-map, INTx interrupts not possible\n",
		pci_controller_name);

... Which tells the user exaclty what we know, and doesn't imply
either
an error or the actual absence of HW support.

Works for me.

Cheers,
Ben.

Thanks very much Ben and Mark, for the good suggestions you gave me.
I was talking on IRC today with Mark, about showing a message once per
device (and not in all its functions) about LSI being not available in
that slot, besides the simple/small messages per function, saying
interrupt-map wasn't found.

I'm working on V2, but will delay a bit to send - I'm out next 20 days.
When I'm back, I'll send the improved version. Oh, I removed positive
return value - never will use it again, noticed isn't that popular heheh

Thanks,


Guilherme