Re: [PATCH 2/2] usb: dwc2: fixes host_dma logic
From: John Youn <hidden>
Date: 2016-11-14 22:53:22
Also in:
linux-devicetree, lkml
On 11/11/2016 12:59 PM, Christian Lamparter wrote:
This patch moves the the host_dma initialization
before dwc2_set_param_dma_desc_enable and
dwc2_set_param_dma_desc_fs_enable. The reason being
that both function need it.
Fixes: 1205489cee75bf39 ("usb: dwc2: Get host DMA device properties")This should probably be omitted since it's only in Felipe's testing/next. Otherwise looks good. Acked-by: John Youn <redacted> Regards, John
quoted hunk ↗ jump to hunk
Cc: John Youn <redacted> Cc: Felipe Balbi <redacted> Signed-off-by: Christian Lamparter <redacted> --- drivers/usb/dwc2/params.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index 5d822c5..222a83c 100644 --- a/drivers/usb/dwc2/params.c +++ b/drivers/usb/dwc2/params.c@@ -1157,9 +1157,6 @@ static void dwc2_set_parameters(struct dwc2_hsotg *hsotg, bool dma_capable = !(hw->arch == GHWCFG2_SLAVE_ONLY_ARCH); dwc2_set_param_otg_cap(hsotg, params->otg_cap); - dwc2_set_param_dma_desc_enable(hsotg, params->dma_desc_enable); - dwc2_set_param_dma_desc_fs_enable(hsotg, params->dma_desc_fs_enable); - if ((hsotg->dr_mode == USB_DR_MODE_HOST) || (hsotg->dr_mode == USB_DR_MODE_OTG)) { bool disable;@@ -1174,6 +1171,8 @@ static void dwc2_set_parameters(struct dwc2_hsotg *hsotg, !disable, false, dma_capable); } + dwc2_set_param_dma_desc_enable(hsotg, params->dma_desc_enable); + dwc2_set_param_dma_desc_fs_enable(hsotg, params->dma_desc_fs_enable); dwc2_set_param_host_support_fs_ls_low_power(hsotg, params->host_support_fs_ls_low_power);