Re: [RESEND] tools-powerpc: Return false instead of -1
From: Michael Ellerman <hidden>
Date: 2016-11-14 12:17:33
Also in:
linux-api, lkml
On Wed, 2016-09-11 at 08:55:04 UTC, Andrew Shadura wrote:
From: Peter Senna Tschudin <peter.senna@gmail.com>
Returning a negative value for a boolean function seem to have the
undesired effect of returning true. require_paranoia_below() is a
boolean function, but the variable used to store the return value is an
integer, receiving -1 or 0. This patch convert rc to bool, replace -1
by false, and 0 by true.
This issue was found by the following Coccinelle semantic patch:
<smpl>
@@
identifier f, ret;
constant C;
typedef bool;
@@
bool f (...){
<+...
ret = -C;
...
* return ret;
...+>
}
</smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Andrew Shadura <redacted>Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/0e27d27e0d6d92342797e0d37738c2 cheers