Thread (29 messages) flat view 29 messages, 10 authors, 2016-11-09

Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet

From: David Miller <davem@davemloft.net>
Date: 2016-11-07 15:55:08
Also in: lkml, netdev

From: Madalin-Cristian Bucur <madalin.bucur@nxp.com>
Date: Mon, 7 Nov 2016 15:43:26 +0000
quoted
From: David Miller [mailto:davem@davemloft.net]
Sent: Thursday, November 03, 2016 9:58 PM

Why?  By clearing this, you disallow an important fundamental way to do
performane testing, via pktgen.
The Tx path in DPAA requires one to insert a back-pointer to the skb into
the Tx buffer. On the Tx confirmation path the back-pointer in the buffer
is used to release the skb. If Tx buffer is shared we'd alter the back-pointer
and leak/double free skbs. See also 
Then have your software state store an array of SKB pointers, one for each
TX ring entry, just like every other driver does.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help