Thread (10 messages) flat view 10 messages, 3 authors, 2016-10-12

Re: [PATCH v2 0/7] PCI: layerscape: Cleanups

From: Bjorn Helgaas <helgaas@kernel.org>
Date: 2016-10-12 16:06:44
Also in: linux-pci

On Wed, Oct 12, 2016 at 08:57:22AM -0500, Bjorn Helgaas wrote:
  - Add local "dev" pointers to reduce repetition of things like
    "&pdev->dev".

  - Remove platform drvdata because it appears unused (we called
    platform_set_drvdata() but not platform_get_drvdata()).

  - Remove redundant struct members.

  - Pass device-specific struct to internal functions for consistency.

  - Move struct pcie_port setup to probe function for consistency.

  - Remove unused ls_add_pcie_port() platform_device argument.

Nothing here should change the behavior of the driver.

Changes from v1:
  I dropped the following patch because it was a lot of churn for
  questionable benefit:
    PCI: layerscape: Name private struct pointer "ls" consistently

---

Bjorn Helgaas (7):
      PCI: layerscape: Add local struct device pointers
      PCI: layerscape: Remove unused platform data
      PCI: layerscape: Remove redundant struct ls_pcie.dbi
      PCI: layerscape: Pass device-specific struct to internal functions
      PCI: layerscape: Move struct pcie_port setup to probe function
      PCI: layerscape: Remove unused ls_add_pcie_port() platform_device arg
      PCI: layerscape: Reorder struct ls_pcie


 drivers/pci/host/pci-layerscape.c |   65 +++++++++++++++++++------------------
 1 file changed, 33 insertions(+), 32 deletions(-)
I applied these to pci/host-layerscape for v4.9.  I hope to ask Linus to
pull them tomorrow, so if you see any issues, let me know soon.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help