Re: [PATCH v6 02/11] locking/osq: Drop the overload of osq_lock()

On Fri, 28 Oct 2016, Pan Xinhui wrote:

		/*
		 * If we need to reschedule bail... so we can block.
+		 * Use vcpu_is_preempted to detech lock holder preemption issue

                                           ^^ detect

+		 * and break.

Could you please remove the rest of this comment? Its just noise to point out
that vcpu_is_preempted is a macro defined by arch/false. This is standard protocol
in the kernel.

Same goes for all locks you change with this.

Thanks,
Davidlohr

               * vcpu_is_preempted is a macro defined by false if
+		 * arch does not support vcpu preempted check,
		 */
-		if (need_resched())
+		if (need_resched() || vcpu_is_preempted(node_cpu(node->prev)))
			goto unqueue;

		cpu_relax_lowlatency();
-- 
2.4.11