Re: [PATCH] powerpc: process.c: fix Kconfig typo

Valentin Rothberg [off-list ref] writes:

quoted

On Wed, Oct 26, 2016 at 7:52 AM, Michael Ellerman [off-list ref] wrote:

quoted

Cyril Bur [off-list ref] writes:

quoted

On Wed, 2016-10-05 at 07:57 +0200, Valentin Rothberg wrote:

quoted

s/ALIVEC/ALTIVEC/

Oops, nice catch

quoted

Signed-off-by: Valentin Rothberg <redacted>

Reviewed-by: Cyril Bur <redacted>

How did we not notice? Sounds like we need a new selftest.

Looks like this should have:

Fixes: dc16b553c949 ("powerpc: Always restore FPU/VEC/VSX if hardware transactional memory in use")


And I guess I need to start running checkkconfigsymbols.py on every
commit.

Happy to find a new user :-)  You can also run the script on a range
of commits via '--diff commitA..commitB', which can safe some time.

Yeah I just discovered that, very useful.

But my instinct was to do:

$ ./scripts/checkkconfigsymbols.py --diff HEAD^^^..HEAD

Which didn't work, the regexp is a bit tight, fixed by:

diff --git a/scripts/checkkconfigsymbols.py b/scripts/checkkconfigsymbols.py
index a32e4da4c117..3820f00b066a 100755
--- a/scripts/checkkconfigsymbols.py
+++ b/scripts/checkkconfigsymbols.py

@@ -88,7 +88,7 @@ def parse_options():
     if args.commit and args.diff:
         sys.exit("Please specify only one option at once.")

-    if args.diff and not re.match(r"^[\w\-\.]+\.\.[\w\-\.]+$", args.diff):
+    if args.diff and not re.match(r"^[\w\-\.\^]+\.\.[\w\-\.\^]+$", args.diff):
         sys.exit("Please specify valid input in the following format: "
                  "\'commit1..commit2\'")