Re: [PATCH v4 5/5] x86, kvm: support vcpu preempted check

From
Paolo Bonzini <pbonzini@redhat.com>
Date
2016-10-24 14:39:56
Also in
kvm, linux-s390, lkml
Reply to
Radim Krčmář, 2016-10-19

On 19/10/2016 19:24, Radim Krčmář wrote:
quoted
quoted
+	if (vcpu->arch.st.msr_val & KVM_MSR_ENABLED)
+		if (kvm_read_guest_cached(vcpu->kvm, &vcpu->arch.st.stime,
+					&vcpu->arch.st.steal,
+					sizeof(struct kvm_steal_time)) == 0) {
+			vcpu->arch.st.steal.preempted = 1;
+			kvm_write_guest_cached(vcpu->kvm, &vcpu->arch.st.stime,
+					&vcpu->arch.st.steal,
+					sizeof(struct kvm_steal_time));
+		}
Please name this block of code.  Something like
  kvm_steal_time_set_preempted(vcpu);
While at it:

1) the kvm_read_guest_cached is not necessary.  You can rig the call to
kvm_write_guest_cached so that it only writes vcpu->arch.st.steal.preempted.

2) split the patch in host and guest sides.

Paolo
Thread (16 messages) 16 messages, 6 authors, last reply 2016-10-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help