Re: [PATCH v3 02/16] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly
From: Steffen Maier <hidden>
Date: 2016-10-13 16:52:17
Also in:
linux-scsi, lkml
Hm, still behaves for me like I reported for v2: http://marc.info/?l=3Dlinux-scsi&m=3D147637177902937&w=3D2 On 10/13/2016 05:00 PM, Johannes Thumshirn wrote:
Don't use fc_bsg_job::request and fc_bsg_job::reply directly, but use helper variables bsg_request and bsg_reply. This will be helpfull when=
transitioning to bsg-lib. Signed-off-by: Johannes Thumshirn <redacted> Reviewed-by: Hannes Reinecke <hare@suse.com> --- drivers/s390/scsi/zfcp_fc.c | 9 +- drivers/scsi/bfa/bfad_bsg.c | 40 +++--- drivers/scsi/ibmvscsi/ibmvfc.c | 22 ++-- drivers/scsi/libfc/fc_lport.c | 23 ++-- drivers/scsi/lpfc/lpfc_bsg.c | 194 +++++++++++++++++----------- drivers/scsi/qla2xxx/qla_bsg.c | 264 ++++++++++++++++++++++---------=
--------
drivers/scsi/qla2xxx/qla_iocb.c | 5 +- drivers/scsi/qla2xxx/qla_isr.c | 46 ++++--- drivers/scsi/qla2xxx/qla_mr.c | 10 +- drivers/scsi/scsi_transport_fc.c | 37 +++--- 10 files changed, 387 insertions(+), 263 deletions(-)
quoted hunk ↗ jump to hunk
diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_trans=
port_fc.c
quoted hunk ↗ jump to hunk
index 8ff2067..eafc7555 100644--- a/drivers/scsi/scsi_transport_fc.c +++ b/drivers/scsi/scsi_transport_fc.c
quoted hunk ↗ jump to hunk
@@ -3973,8 +3981,9 @@ enum fc_dispatch_result { /* check if we have the msgcode value at least */ if (job->request_len < sizeof(uint32_t)) { BUG_ON(job->reply_len < sizeof(uint32_t)); - job->reply->reply_payload_rcv_len =3D 0; - job->reply->result =3D -ENOMSG; + bsg_reply =3D job->reply; + bsg_reply->reply_payload_rcv_len =3D 0; + bsg_reply->result =3D -ENOMSG; job->reply_len =3D sizeof(uint32_t); fc_bsg_jobdone(job); spin_lock_irq(q->queue_lock);
--=20 Mit freundlichen Gr=FC=DFen / Kind regards Steffen Maier Linux on z Systems Development IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz Geschaeftsfuehrung: Dirk Wittkopp Sitz der Gesellschaft: Boeblingen Registergericht: Amtsgericht Stuttgart, HRB 243294