Thread (3 messages) flat view 3 messages, 3 authors, 2016-10-08

Re: [PATCH] wan/fsl_ucc_hdlc: Fix size used in dma_free_coherent()

From: David Miller <davem@davemloft.net>
Date: 2016-10-08 04:05:43
Also in: kernel-janitors, lkml, netdev

From: Christophe JAILLET <redacted>
Date: Fri,  7 Oct 2016 22:58:47 +0200
Size used with 'dma_alloc_coherent()' and 'dma_free_coherent()' should be
consistent.
Here, the size of a pointer is used in dma_alloc... and the size of the
pointed structure is used in dma_free...

This has been spotted with coccinelle, using the following script:
////////////////////
@r@
expression x0, x1, y0, y1, z0, z1, t0, t1, ret;
@@

*   ret = dma_alloc_coherent(x0, y0, z0, t0);
    ...
*   dma_free_coherent(x1, y1, ret, t1);


@script:python@
y0 << r.y0;
y1 << r.y1;

@@
if y1.find(y0) == -1:
 print "WARNING: sizes look different:  '%s'   vs   '%s'" % (y0, y1)
////////////////////

Signed-off-by: Christophe JAILLET <redacted>
Looks good to me, applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help