[PATCH 1/3] powerpc/eeh: Null check uses of eeh_pe_bus_get · Russell Currey <hidden> · 2016-09-12
[PATCH 3/3] powerpc/eeh: Skip finding bus until after failure reporting · Russell Currey <hidden> · 2016-09-12
Re: [PATCH 3/3] powerpc/eeh: Skip finding bus until after failure reporting · Andrew Donnellan <hidden> · 2016-09-12
[PATCH 2/3] powernv/eeh: Skip finding bus for VF resets · Russell Currey <hidden> · 2016-09-12
Re: [PATCH 2/3] powernv/eeh: Skip finding bus for VF resets · Andrew Donnellan <hidden> · 2016-09-12
Re: [PATCH 1/3] powerpc/eeh: Null check uses of eeh_pe_bus_get · Andrew Donnellan <hidden> · 2016-09-12
Re: [1/3] powerpc/eeh: Null check uses of eeh_pe_bus_get · Michael Ellerman <mpe@ellerman.id.au> · 2016-09-21
Re: [1/3] powerpc/eeh: Null check uses of eeh_pe_bus_get · Russell Currey <hidden> · 2016-09-21
Re: [1/3] powerpc/eeh: Null check uses of eeh_pe_bus_get · Michael Ellerman <hidden> · 2016-09-25

Re: [PATCH 3/3] powerpc/eeh: Skip finding bus until after failure reporting

From: Andrew Donnellan <hidden>
Date: 2016-09-12 04:41:55

On 12/09/16 14:17, Russell Currey wrote:

In eeh_handle_special_event(), eeh_pe_bus_get() is called before calling
eeh_report_failure() on every device under a PE.  If a PE was missing a
bus for some reason, the error would occur before reporting failure, even
though eeh_report_failure() doesn't require a bus.

Fix this by moving the bus retrieval and error check after the
eeh_report_failure() calls.

Cc: stable #3.10+
Signed-off-by: Russell Currey <redacted>

Looks good to me.

Reviewed-by: Andrew Donnellan <redacted>

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com  IBM Australia Limited

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help