Thread (50 messages) 50 messages, 4 authors, 2016-10-04

Re: [PATCH v21 00/20] perf, tools: Add support for PMU events in JSON format

From: Jiri Olsa <hidden>
Date: 2016-09-26 08:35:42
Also in: lkml

On Thu, Sep 22, 2016 at 06:27:13PM +0200, Jiri Olsa wrote:
On Thu, Sep 22, 2016 at 05:00:22PM +0200, Jiri Olsa wrote:
quoted
On Mon, Sep 19, 2016 at 09:28:20PM -0300, Arnaldo Carvalho de Melo wrote:
quoted
Em Mon, Sep 19, 2016 at 09:02:58PM -0300, Arnaldo Carvalho de Melo escreveu:
quoted
Em Mon, Sep 19, 2016 at 08:37:53PM -0300, Arnaldo Carvalho de Melo escreveu:
quoted
yeah, changing that typedef + true def to plain include <stdbool.h>
makes it progress to the next failure, which is in cross compilation
environments, such as using fedora 24 + the Android NDK to try to build
a ARM android binary.
quoted
14 fedora:24-x-ARC-uClibc: FAIL
  GEN      /tmp/build/perf/pmu-events/pmu-events.c
/bin/sh: /tmp/build/perf/pmu-events/jevents: cannot execute binary file: Exec format error
pmu-events/Build:11: recipe for target '/tmp/build/perf/pmu-events/pmu-events.c' failed
make[2]: *** [/tmp/build/perf/pmu-events/pmu-events.c] Error 126
Makefile.perf:461: recipe for target '/tmp/build/perf/pmu-events/pmu-events-in.o' failed
make[1]: *** [/tmp/build/perf/pmu-events/pmu-events-in.o] Error 2
make[1]: *** Waiting for unfinished jobs....
Jiri, we need something similar to scripts/Makefile.host :-\

Calling it a day, perhaps, for now, we should just detect that it is a
corss compile env (CROSS_COMPILE is set) and exclude all this code from
the build, emitting a warning.

I left what I did at the tmp.perf/core branch of my repo at
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git.
as discussed on irc we will disable it for cross builds now,
because we dont have good solution at the moment.. it's
similar case as for fixdep tool:

    3a70fcd3a4db tools build: Fix cross compile build
    ...
    We need to add support for host side tools build, meanwhile
    disabling fixdep usage for cross arch builds.

I'll make a change to disable this for crossbuild and
work on common solution later
could you please give it a try with patch below?
I tested but not with properly cross building...

also,  did you want some message during the cross build that pmu-events are not included?
ping.. is that working for you? IMO we can include this
as additional patch to the set..

thanks,
jirka
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help