Re: [PATCH v7 0/6] perf annotate: Cross arch support + few fixes

On Thu, 22 Sep 2016 10:48:13 +0530
Ravi Bangoria [off-list ref] wrote:

On Thursday 22 September 2016 01:04 AM, Kim Phillips wrote:

quoted

On Wed, 21 Sep 2016 21:17:50 +0530
Ravi Bangoria [off-list ref] wrote:

quoted

Kim, I don't have arm test machine. Can you please help me to test
this on arm.

This works for me:  hitting return on return instructions yields
"Invalid jump offset", but I'll get that later.

Thanks Kim.

Hmm.. so, ins__find_arm does not contain logic for return instructions. Navigation
with return instruction is working fine for x86 and powerpc.

Right, for ARM, in order to match return instructions, 'lr' must be
found to be the operand of the branch instruction, which is not
contained in the 'name' variable passed to ins__find().

I don't want this to inhibit acceptance of this series, however: I plan
on addressing it afterwards, unless, of course, it is perceived as a
problem somehow (compatibility-wise, it is not because it is an error
at the moment).

Thanks,

Kim