Thread (6 messages) flat view 6 messages, 5 authors, 2016-09-13

Re: [PATCH] powerpc/32: add missing \n at end of printk warning message

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2016-09-13 01:26:03
Also in: lkml

Christophe Leroy [off-list ref] writes:
Le 12/09/2016 =C3=A0 12:12, Colin King a =C3=A9crit :
quoted
diff --git a/arch/powerpc/mm/init_32.c b/arch/powerpc/mm/init_32.c
index 448685f..b532dd9 100644
--- a/arch/powerpc/mm/init_32.c
+++ b/arch/powerpc/mm/init_32.c
@@ -137,7 +137,7 @@ void __init MMU_init(void)
 	if (memblock.memory.cnt > 1) {
 #ifndef CONFIG_WII
 		memblock_enforce_memory_limit(memblock.memory.regions[0].size);
-		printk(KERN_WARNING "Only using first contiguous memory region");
+		printk(KERN_WARNING "Only using first contiguous memory region\n");
This line was already 81 characters long. It is now 83.
That doesn't really bother me.
I would suggest to use pr_warn() instead in order to shorten the line.
But I do like pr_warn(), it's less shouty.

I'll fix it up when I apply it.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help