Thread (28 messages) 28 messages, 5 authors, 2016-09-14

Re: [PATCH v20 00/20] perf, tools: Add support for PMU events in JSON format

From: Jiri Olsa <hidden>
Date: 2016-08-31 14:55:04
Also in: lkml

On Wed, Aug 31, 2016 at 07:42:47AM -0700, Andi Kleen wrote:
quoted
hi,
I had discussion with Ingo about the state of this patchset
and there's one more requirement from his side - to split
event files into per topic files
Thanks Jiri.
quoted
I made some initial changes over latest Sukadev's branch
and came up with something like this:
Did you just split it by the "Topic" fields?
yep
quoted
	$ find pmu-events/arch/x86/
	pmu-events/arch/x86/
	pmu-events/arch/x86/NehalemEX_core
	pmu-events/arch/x86/NehalemEX_core/Memory.json
	pmu-events/arch/x86/NehalemEX_core/Virtual-Memory.json
	pmu-events/arch/x86/NehalemEX_core/Cache.json
	pmu-events/arch/x86/NehalemEX_core/Pipeline.json
	pmu-events/arch/x86/NehalemEX_core/Floating-point.json
	pmu-events/arch/x86/NehalemEX_core/Other.json
	pmu-events/arch/x86/mapfile.csv
	pmu-events/arch/x86/Broadwell_core
	pmu-events/arch/x86/Broadwell_core/Memory.json
	pmu-events/arch/x86/Broadwell_core/Virtual-Memory.json
	pmu-events/arch/x86/Broadwell_core/Cache.json
	pmu-events/arch/x86/Broadwell_core/Pipeline.json
	pmu-events/arch/x86/Broadwell_core/Floating-point.json
	pmu-events/arch/x86/Broadwell_core/Other.json
	pmu-events/arch/x86/Broadwell_core/Frontend.json

so let's have a discussion if this is acceptable for you guys
Splitting is fine for me, as long as it's scriptable.

I already have some scripts to generate the perf json files,
can update them to split.
yep, there's split-json.py script earlier in the perf/json branch
quoted
I've already made some changes in pmu-events/* to support
this hierarchy to see how bad the change would be.. and
it's not that bad ;-)
Everything has to be automated, please no manual changes.
sure

so, if you're ok with the layout, how do you want to proceed further?

thanks,
jirka
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help