Re: [PATCH] hwrng: pasemi_rng.c: Migrate to managed API
From: LABBE Corentin <clabbe.montjoie@gmail.com>
Date: 2016-08-25 12:17:11
Also in:
linux-crypto, lkml
On Thu, Aug 25, 2016 at 05:04:16PM +0530, PrasannaKumar Muralidharan wrote:
quoted hunk ↗ jump to hunk
Use devm_ioremap and devm_hwrng_register instead of ioremap and hwrng_register. This removes unregistering and error handling code. This patch is not tested with hardware as I don't have access to it. Signed-off-by: PrasannaKumar Muralidharan <redacted> --- drivers/char/hw_random/pasemi-rng.c | 26 +++----------------------- 1 file changed, 3 insertions(+), 23 deletions(-)diff --git a/drivers/char/hw_random/pasemi-rng.c b/drivers/char/hw_random/pasemi-rng.c index 699b725..0f03397 100644 --- a/drivers/char/hw_random/pasemi-rng.c +++ b/drivers/char/hw_random/pasemi-rng.c@@ -100,37 +100,18 @@ static int rng_probe(struct platform_device *ofdev) void __iomem *rng_regs; struct device_node *rng_np = ofdev->dev.of_node; struct resource res; - int err = 0; - err = of_address_to_resource(rng_np, 0, &res); - if (err) + if (of_address_to_resource(rng_np, 0, &res)) return -ENODEV; - rng_regs = ioremap(res.start, 0x100); - + rng_regs = devm_ioremap(&ofdev->dev, res.start, 0x100); if (!rng_regs) return -ENOMEM;
I will propose to use devm_ioremap_resource() instead for removing this hardcoded 0x100, but i cannot find any user of this driver in any dts. (And so cannot check that this 0x100 is given in any DT resource node) Is this normal ? Regard