Re: [PATCH 11/15] zram: Pass attribute group to device_add_disk
From: Sergey Senozhatsky <hidden>
Date: 2016-08-18 02:06:39
Also in:
linux-block, linux-nvme, lkml, virtualization
On (08/18/16 10:59), Sergey Senozhatsky wrote: [..]
I like the previous "Error creating sysfs group for device" string better,
than "Error creating disk", because the latter one is much less informative.
do you want to do something like below?
int device_add_disk(struct device *parent, struct gendisk *disk,
...
if (attr_group) {
retval = sysfs_create_group(&disk_to_dev(disk)->kobj,
attr_group);
+ pr_err("Error creating sysfs group for device ...\n", ...);d'oh... a typo. pr_err() is meant to be in `if (retval)' branch.
if (retval)
goto fail;
}-ss