On 17/08/16 04:49, Thiago Jung Bauermann wrote:

Am Dienstag, 16 August 2016, 16:15:55 schrieb Balbir Singh:

quoted

On 16/08/16 00:49, Thiago Jung Bauermann wrote:

quoted

Am Montag, 15 August 2016, 17:30:49 schrieb Balbir Singh:

quoted

On Thu, Aug 11, 2016 at 08:08:07PM -0300, Thiago Jung Bauermann wrote:

quoted

Adapt all callers to the new function prototype.

Could you please expand on this?

Is the following better?

Adapt all callers to set up a kexec_buf to pass to kexec_add_buffer.

Yes and the reason for doing so? Consolidation/clarity of implementation?

Indeed. What about this commit message?

Subject: [PATCH v5 02/13] kexec_file: Change kexec_add_buffer to take  
 kexec_buf as argument.

This is done to simplify the kexec_add_buffer argument list.
Adapt all callers to set up a kexec_buf to pass to kexec_add_buffer.

In addition, change the type of kexec_buf.buffer from char * to void *.
There is no particular reason for it to be a char *, and the change
allows us to get rid of 3 existing casts to char * in the code.

Signed-off-by: Thiago Jung Bauermann <redacted>
Acked-by: Dave Young <redacted>
Acked-by: Balbir Singh <bsingharora@gmail.com>

Looks good

Balbir