On Tuesday 26 July 2016 05:51 PM, Benjamin Herrenschmidt wrote:

On Mon, 2016-07-25 at 20:22 +0530, Madhavan Srinivasan wrote:

quoted

But this patchset uses Benjamin Herrenschmidt suggestion of using
arch_local_irq_disable_var() to soft_disable interrupts (including PMIs).
After finishing the "op", arch_local_irq_restore() called and correspondingly
interrupts are replayed if any occured.

I am not fan of "var", we probably want "level".

Sure. Will do

Also be careful, you might be already soft-disabled at level 1, you
must restore to level 1, not level 0 in that case. Might want to
actually return the level in "flags" and restore that.

Yes. Thats correct. I return the current flag value.

Maddy

Cheers,
Ben.