Re: [v2] powerpc/powernv: fix pci-cxl.c build when CONFIG_MODULES=n
From: Michael Ellerman <hidden>
Date: 2016-07-20 09:10:24
On Tue, 2016-19-07 at 02:33:35 UTC, Ian Munsie wrote:
From: Ian Munsie <redacted>
pnv_cxl_enable_phb_kernel_api() grabs a reference to the cxl module to
prevent it from being unloaded after the PHB has been switched to CX4 mode.
This breaks the build when CONFIG_MODULES=n as module_mutex doesn't exist.
However, if we don't have modules, we don't need to protect against the
case of the cxl module being unloaded. As such, split the relevant
code out into a function surrounded with #if IS_MODULE(CXL) so we don't try
to compile it if cxl isn't being compiled as a module.
Fixes: 5918dbc9b4ec ("powerpc/powernv: Add support for the cxl kernel api
on the real phb")
Reported-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Ian Munsie <redacted>
Signed-off-by: Andrew Donnellan <redacted>Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/c2ca9f6b4cc4c45eb598b24b8b cheers