Re: [v2, 1/3] powerpc32: booke: fix the build error when CRASH_DUMP is enabled
From: Michael Ellerman <hidden>
Date: 2016-07-20 09:10:20
On Wed, 2016-13-07 at 01:14:38 UTC, Kevin Hao wrote:
In the current code, the RELOCATABLE will be forcedly enabled when
enabling CRASH_DUMP. But for ppc32, the RELOCABLE also depend on
ADVANCED_OPTIONS and select NONSTATIC_KERNEL. This will cause the
following build error when CRASH_DUMP=y && ADVANCED_OPTIONS=n
because the select of NONSTATIC_KERNEL doesn't take effect.
arch/powerpc/include/asm/io.h: In function 'virt_to_phys':
arch/powerpc/include/asm/page.h:113:26: error: 'virt_phys_offset' undeclared (first use in this function)
#define VIRT_PHYS_OFFSET virt_phys_offset
^
It doesn't have any strong reasons to make the RELOCATABLE depend on
ADVANCED_OPTIONS. So remove this dependency to fix this issue.
Signed-off-by: Kevin Hao <redacted>Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/da4230714662278781d007fb2b cheers