Thread (26 messages) flat view 26 messages, 4 authors, 2016-07-19

Re: [PATCH V2 4/5] kvm/stats: Add provisioning for 64-bit vcpu statistics

From: Paolo Bonzini <pbonzini@redhat.com>
Date: 2016-07-14 09:43:01
Also in: kvm


On 13/07/2016 20:00, Christian Borntraeger wrote:
quoted
quoted
quoted
quoted
I thought u64 still existed on 32-bit architectures. unsigned long
would be fine but with the caveat that certain stats would overflow on
32-bit architectures.
Yes, but not all 32-bit architectures can do atomic read-modify-write
(e.g. add) operations on 64-bit values.
So what about only doing it for the VCPU events? Those should be only
modified by one CPU. We would have some odd values on 32bit overflow, but
this will be certainly better than just start with 0
If that's good enough for PPC, that's fine.

Paolo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help