[bug report] cxl: sysfs support for guests

Started by Dan Carpenter on Jul 13, 2016

open the first message on its own page

Message details and related content
Hello Christophe Lombard,

The patch 4752876c7170: "cxl: sysfs support for guests" from Mar 4,
2016, leads to the following static checker warning:

	drivers/misc/cxl/sysfs.c:681 cxl_sysfs_afu_add()
	warn: if statement not indented

drivers/misc/cxl/sysfs.c
   672  err1:
   673          cxl_sysfs_afu_remove(afu);
   674          return rc;
   675  err:
   676          /* reset the eb_len as we havent created the bin attr */
   677          afu->eb_len = 0;
   678  
   679          for (i--; i >= 0; i--) {
   680                  dev_attr = &afu_attrs[i];
   681                  if (cxl_ops->support_attributes(dev_attr->attr.name,
   682                                                  CXL_AFU_ATTRS))
   683                  device_remove_file(&afu->dev, &afu_attrs[i]);

It's tempting to add a tab but I *think* actually there is a line
missing here?  I'm not sure.

   684          }
   685          return rc;
   686  }

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help