Re: t1040 IFC flash driver Extended Chip Select
From: Scott Wood <hidden>
Date: 2016-07-07 05:30:49
On 07/06/2016 03:23 PM, Daniel Walker wrote:=0A=
Hi,=0A= =0A= We are using the t1040 platform, and we have found that we need to =0A= populate this register. In the Technical Reference Manual it's =0A= description is section 24.3.2. This option appears in the driver, but it =
=0A=
doesn't appears to be used anyplace.=0A=
=0A= I'm not sure what you mean by "in the driver". U-boot sets these registers= .=0A= =0A=
We we're considered adding something to the device tree to allow =0A= populating this value, but I'm wondering if any of you have specific =0A= considerations on how this is done. Or maybe it's not needed at all, and =
=0A=
quoted hunk ↗ jump to hunk
we're just missing something.=0A= =0A= (not a good patch, just an example.)=0A= =0A=diff --git =0A=a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt =0A= b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt=0A= index 89427b0..b506001 100644=0A=--- a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt=0A= +++ b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt=0A=@@ -24,6 +24,8 @@ Properties:=0A= - ranges : Each range corresponds to a single chipselect, and covers=0A= the entire access window as configured.=0A==0A= +- cspr_ext : This value sets the extended chip select for all banks.=0A=
=0A= I see no reason to put this here. Boot software should be setting the=0A= chipselect registers, and if for some reason you don't want to do that,=0A= you could just translate the address through ranges to find the value to=0A= write. Why would you have the binding assume it's the same for all banks?= =0A= =0A= The information that is missing from the device tree, that currently=0A= must come from boot software programming the registers, is the various=0A= attributes that get programmed in CSPR/CSOR.=0A= =0A= -Scott=0A= =0A=