Re: [PATCH 07/14] cxl: Add support for using the kernel API with a real PHB
From: Frederic Barrat <hidden>
Date: 2016-07-06 18:30:59
quoted hunk ↗ jump to hunk
@@ -1572,6 +1575,9 @@ static pci_ers_result_t cxl_pci_error_detected(struct pci_dev *pdev, */ for (i = 0; i < adapter->slices; i++) { afu = adapter->afu[i]; + /* Only participate in EEH if we are on a virtual PHB */ + if (afu->phb == NULL) + return PCI_ERS_RESULT_NONE; cxl_vphb_error_detected(afu, state); }
Sorry, I had my notes out of order, something is bugging me here. Don't we always define afu->phb, though for Mellanox (or if there's no config record in the general case), we don't have any devices attached to it? Which raises the question of the handling of slot_reset and resume callbacks... Fred