Re: [PATCH 3/6] powerpc/xics: Fully qualify cast to silence sparse

From
Arnd Bergmann <arnd@arndb.de>
Date
2016-07-04 07:43:29
Reply to
Daniel Axtens, 2016-07-04
On Monday, July 4, 2016 5:09:39 PM CEST Daniel Axtens wrote:
quoted hunk ↗ jump to hunk
Make the cast fully line up with what out_rm8 expects.

Signed-off-by: Daniel Axtens <redacted>
---
 arch/powerpc/sysdev/xics/icp-native.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/sysdev/xics/icp-native.c b/arch/powerpc/sysdev/xics/icp-native.c
index afdf62f2a695..e9cffb06cc01 100644
--- a/arch/powerpc/sysdev/xics/icp-native.c
+++ b/arch/powerpc/sysdev/xics/icp-native.c
@@ -176,7 +176,7 @@ void icp_native_cause_ipi_rm(int cpu)
         * causing the IPI.
         */
        xics_phys = paca[cpu].kvm_hstate.xics_phys;
-       out_rm8((u8 *)(xics_phys + XICS_MFRR), IPI_PRIORITY);
+       out_rm8((volatile u8 __iomem *)(xics_phys + XICS_MFRR), IPI_PRIORITY);
 }
We don't normally mark pointers as 'volatile' when passing them
to the MMIO accessors. The reason that they take a volatile argument
is mainly to avoid a warning for drivers that for historic reasons
use volatile pointers intead of __iomem pointers.

	Arnd
Thread (13 messages) 13 messages, 4 authors, 2016-07-04
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help