Re: [V2,1/2] tty/hvc: Use IRQF_SHARED for OPAL hvc consoles
From: Michael Ellerman <hidden>
Date: 2016-07-27 14:32:47
Also in:
stable
On Mon, 2016-11-07 at 03:38:57 UTC, Sam Mendoza-Jonas wrote:
Commit 2def86a7200c
("hvc: Convert to using interrupts instead of opal events")
enabled the use of interrupts in the hvc_driver for OPAL platforms.
However on machines with more than one hvc console, any console after
the first will fail to register an interrupt handler in
notifier_add_irq() since all consoles share the same IRQ number but do
not set the IRQF_SHARED flag:
[ 51.179907] genirq: Flags mismatch irq 31. 00000000 (hvc_console) vs.
00000000 (hvc_console)
[ 51.180010] hvc_open: request_irq failed with rc -16.
This error propagates up to hvc_open() and the console is closed, but
OPAL will still generate interrupts that are not handled, leading to
rcu_sched stall warnings.
Set IRQF_SHARED when calling request_irq, allowing additional consoles
to start properly. This is only set for consoles handled by
hvc_opal_probe(), leaving other types unaffected.
Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>
Acked-by: Michael Ellerman <mpe@ellerman.id.au>Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/bbc3dfe8805de86874b1a1b142 cheers