Thread (4 messages) 4 messages, 3 authors, 2016-07-16

Re: [PATCH v2] cpufreq: powernv: Replacing pstate_id with frequency table index

From: Rafael J. Wysocki <hidden>
Date: 2016-07-16 00:57:50
Also in: linux-pm, lkml

On Monday, July 11, 2016 11:47:53 AM Viresh Kumar wrote:
On 30-06-16, 11:53, Akshay Adiga wrote:
quoted
Refactoring code to use frequency table index instead of pstate_id.
This abstraction will make the code independent of the pstate values.

- No functional changes
- The highest frequency is at frequency table index 0 and the frequency
  decreases as the index increases.
- Macros pstates_to_idx() and idx_to_pstate() can be used for conversion
  between pstate_id and index.
- powernv_pstate_info now contains frequency table index to min, max and
  nominal frequency (instead of pstate_ids)
- global_pstate_info new stores index values instead pstate ids.
- variables renamed as *_idx which now store index instead of pstate

Signed-off-by: Akshay Adiga <redacted>
Reviewed-by: Gautham R. Shenoy <redacted>
---
Changes from v1:
  - changed macro names from get_pstate()/ get_index() to 
idx_to_pstate()/ pstate_to_idx()
  - Renamed variables that store index instead of pstate_id to *_idx
  - Retained previous printk's 

v1 : http://marc.info/?l=linux-pm&m=146677701501225&w=1

 drivers/cpufreq/powernv-cpufreq.c | 177 ++++++++++++++++++++++----------------
 1 file changed, 102 insertions(+), 75 deletions(-)
Haven't done in-depth review, but I trust that Gautham has done it :)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Patch applied, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help