On Fri, 2016-07-15 at 14:36 +1000, Michael Ellerman wrote:

Joe Perches [off-list ref] writes:

quoted

Make the compiler detect format and argument mismatches.

Signed-off-by: Joe Perches <joe@perches.com>
---
 arch/powerpc/platforms/powernv/pci.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/platforms/powernv/pci.h

b/arch/powerpc/platforms/powernv/pci.h
index 3a97990..1c1a586 100644

--- a/arch/powerpc/platforms/powernv/pci.h
+++ b/arch/powerpc/platforms/powernv/pci.h

@@ -213,6 +213,7 @@ extern void pnv_pci_dma_bus_setup(struct pci_bus

*bus);
 extern int pnv_setup_msi_irqs(struct pci_dev *pdev, int nvec, int
type);
 extern void pnv_teardown_msi_irqs(struct pci_dev *pdev);
 
+__printf(3, 4)
 extern void pe_level_printk(const struct pnv_ioda_pe *pe, const
char *level,
 			    const char *fmt, ...);

Thanks, but it breaks the build due to lots of new warnings.

We'll have to fix those before merging it.

Good.  Are you going to fix those?

I thought I did a powerpc defconfig build of arch/powerpc/
and I believe it finished without error, but I'm pleased
it found some defects.

I think it's now marked "rejected" in patchwork.
Perhaps it'd better to mark it "deferred" instead.