Re: [v2 PATCH 2/2] cpufreq: qoriq: Don't look at clock implementation details

Hi,

[auto build test WARNING on clk/clk-next]
[also build test WARNING on v4.7-rc2]
[cannot apply to next-20160609]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Scott-Wood/clk-Add-consumer-APIs-for-discovering-possible-parent-clocks/20160612-112523
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: arm-multi_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/cpufreq/qoriq-cpufreq.c: In function 'qoriq_cpufreq_cpu_init':

quoted

drivers/cpufreq/qoriq-cpufreq.c:227:2: warning: 'pnode' may be used uninitialized in this function [-Wmaybe-uninitialized]

     of_node_put(pnode);
     ^

vim +/pnode +227 drivers/cpufreq/qoriq-cpufreq.c

defa4c73 drivers/cpufreq/ppc-corenet-cpufreq.c Tang Yuantian 2013-06-05  211  		pr_err("invalid frequency table: %d\n", ret);
defa4c73 drivers/cpufreq/ppc-corenet-cpufreq.c Tang Yuantian 2013-06-05  212  		goto err_nomem1;
defa4c73 drivers/cpufreq/ppc-corenet-cpufreq.c Tang Yuantian 2013-06-05  213  	}
defa4c73 drivers/cpufreq/ppc-corenet-cpufreq.c Tang Yuantian 2013-06-05  214  
defa4c73 drivers/cpufreq/ppc-corenet-cpufreq.c Tang Yuantian 2013-06-05  215  	data->table = table;
defa4c73 drivers/cpufreq/ppc-corenet-cpufreq.c Tang Yuantian 2013-06-05  216  
defa4c73 drivers/cpufreq/ppc-corenet-cpufreq.c Tang Yuantian 2013-06-05  217  	/* update ->cpus if we have cluster, no harm if not */
a4f20742 drivers/cpufreq/ppc-corenet-cpufreq.c Tang Yuantian 2015-03-13  218  	set_affected_cpus(policy);
a4f20742 drivers/cpufreq/ppc-corenet-cpufreq.c Tang Yuantian 2015-03-13  219  	policy->driver_data = data;
defa4c73 drivers/cpufreq/ppc-corenet-cpufreq.c Tang Yuantian 2013-06-05  220  
906fe033 drivers/cpufreq/ppc-corenet-cpufreq.c Ed Swarthout  2014-06-05  221  	/* Minimum transition latency is 12 platform clocks */
906fe033 drivers/cpufreq/ppc-corenet-cpufreq.c Ed Swarthout  2014-06-05  222  	u64temp = 12ULL * NSEC_PER_SEC;
a4f20742 drivers/cpufreq/ppc-corenet-cpufreq.c Tang Yuantian 2015-03-13  223  	do_div(u64temp, get_bus_freq());
906fe033 drivers/cpufreq/ppc-corenet-cpufreq.c Ed Swarthout  2014-06-05  224  	policy->cpuinfo.transition_latency = u64temp + 1;
6712d293 drivers/cpufreq/ppc-corenet-cpufreq.c Tim Gardner   2014-04-28  225  
defa4c73 drivers/cpufreq/ppc-corenet-cpufreq.c Tang Yuantian 2013-06-05  226  	of_node_put(np);
8a95c144 drivers/cpufreq/qoriq-cpufreq.c       Tang Yuantian 2015-06-04 @227  	of_node_put(pnode);
defa4c73 drivers/cpufreq/ppc-corenet-cpufreq.c Tang Yuantian 2013-06-05  228  
defa4c73 drivers/cpufreq/ppc-corenet-cpufreq.c Tang Yuantian 2013-06-05  229  	return 0;
defa4c73 drivers/cpufreq/ppc-corenet-cpufreq.c Tang Yuantian 2013-06-05  230  
defa4c73 drivers/cpufreq/ppc-corenet-cpufreq.c Tang Yuantian 2013-06-05  231  err_nomem1:
defa4c73 drivers/cpufreq/ppc-corenet-cpufreq.c Tang Yuantian 2013-06-05  232  	kfree(table);
8a95c144 drivers/cpufreq/qoriq-cpufreq.c       Tang Yuantian 2015-06-04  233  err_pclk:
8a95c144 drivers/cpufreq/qoriq-cpufreq.c       Tang Yuantian 2015-06-04  234  	kfree(data->pclk);
defa4c73 drivers/cpufreq/ppc-corenet-cpufreq.c Tang Yuantian 2013-06-05  235  err_nomem2:

:::::: The code at line 227 was first introduced by commit
:::::: 8a95c1441c799bb0f0d31cdb11523d91923d51a7 cpufreq: qoriq: optimize the CPU frequency switching time

:::::: TO: Tang Yuantian [off-list ref]
:::::: CC: Rafael J. Wysocki [off-list ref]

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation