Thread (14 messages) 14 messages, 5 authors, 2016-06-30

Re: [PATCHv2 0/7] eBPF JIT for PPC64

From: Denis Kirjanov <hidden>
Date: 2016-06-30 09:34:37
Also in: lkml

On 6/30/16, Andreas Ziegler [off-list ref] wrote:
Hi Naveen,

this patchset makes a change to arch/powerpc/net/Makefile in order to only
compile the previously existing bpf_jit_comp.c if !CONFIG_PPC64, and use
bpf_jit_comp64.c if CONFIG_PPC64 is enabled.

Inside arch/powerpc/net/bpf_jit_comp.c, however, there is still an #ifdef
CONFIG_PPC64 block at line 667 (linux-next of today, i.e., next-20160630):

  #ifdef CONFIG_PPC64
                  /* Function descriptor nastiness: Address + TOC */
                  ((u64 *)image)[0] = (u64)code_base;
                  ((u64 *)image)[1] = local_paca->kernel_toc;
  #endif

From my understanding of the code, this #ifdef can now be removed, as there
is
no way the file could be compiled with CONFIG_PPC64 enabled. Is this
correct?
That was used for running classic BPF on ppc64. With eBPF on ppc64 the
whole block can be removed.
Best regards,

Andreas
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help