Thread (22 messages) 22 messages, 6 authors, 2016-07-01

Re: [PATCH v2 00/12] gendisk: Generate uevent after attribute available

From: Christoph Hellwig <hch@infradead.org>
Date: 2016-06-30 06:26:22
Also in: linux-block, linux-mmc, linux-nvme, linux-raid, lkml, virtualization

On Thu, Jun 30, 2016 at 09:59:41AM +0800, Fam Zheng wrote:
Documentation/kobject.txt:
quoted
Use the KOBJ_ADD action for when the kobject is first added to the kernel.
This should be done only after any attributes or children of the kobject
have been initialized properly, as userspace will instantly start to look
for them when this call happens.
Unfortunately it seems impossible to fix this generally without touching the
offending callers.  The approach I'm proposing here is adding a flag to
suppress uevent in add_disk(), which is patch 1, then in later patches, convert
any caller to only trigger the uevent when attributes are added.
We (or rather Dan) is touching most add_disk callers anyway for the
driverfs_dev removal.  Let's just pass the array of attributes to
a disk_add variant and solve the issue for real.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help