Re: [PATCH 2/2] perf annotate: add powerpc support

Em Tue, Jun 14, 2016 at 01:40:47PM +1000, Michael Ellerman escreveu:

On Fri, 2016-06-10 at 20:08 +0530, Naveen N. Rao wrote:

quoted

On 2016/06/10 10:36AM, Arnaldo Carvalho de Melo wrote:

quoted

Em Fri, Jun 10, 2016 at 06:32:51PM +0530, Naveen N. Rao escreveu:

quoted

Convert ins__find() to a __weak function for generic functionality,
while adding a powerpc-specific variant. We look at the function name
for branch instructions and classify the instructions to one among a
branch, a function call (branch with LR update) or a function return
(branch to LR).

quoted

quoted

How would this allow one to get a perf.data collected on a powerpc
system, transfer it to a x86-64 (or aarch64, to mention another
workstation wannabe chip) system and then try annotating it?

quoted

quoted

There was a previous discussion about this, and it involved having all
yout ppc tables available as well as other arches tables, and then
choosing which one to use based on:

quoted

quoted

	normalize_arch(thread->mg->machine->env->arch)

quoted

quoted

just like was done for support cross unwinding, see recent patch kit by
He Kuang, CCed.

quoted

Nice. This would be good to have. I will look at adding powerpc support 
for cross-architecture unwind.

quoted

However, for cross-architecture annotation, I think there will be a lot 
more dependencies since perf currently uses objdump to obtain the 
disassembly. In addition, the actual binaries will also be needed.

It's possible to build a multi-arch objdump, I don't know if it's packaged on
all distros, or if perf wants to depend on it.

Somebody noticed that we can specify a different objdump binary, from a
cross toolchain package.

We need to at least check if the objdump being used supports the
architecture where the perf.data file was generated, refusing to process
the file for which there is no support, providing a clear message to
users trying to process such files.

I.e. checking if normalize_arch(thread->mg->machine->env->arch) is one of:

[acme@jouet linux]$ objdump -m 2>&1|grep 'objdump: supported' 
objdump: supported targets: elf64-x86-64 elf32-i386 elf32-x86-64 a.out-i386-linux pei-i386 pei-x86-64 elf64-l1om elf64-k1om elf64-little elf64-big elf32-little elf32-big plugin srec symbolsrec verilog tekhex binary ihex
objdump: supported architectures: i386 i386:x86-64 i386:x64-32 i8086 i386:intel i386:x86-64:intel i386:x64-32:intel i386:nacl i386:x86-64:nacl i386:x64-32:nacl l1om l1om:intel k1om k1om:intel plugin
[acme@jouet linux]$

- Arnaldo