Re: [PATCH v4 09/10] cpuidle/powernv: Add support for POWER ISA v3 idle states

On Tue, 2016-05-31 at 19:20 +0530, Shreyas B Prabhu wrote:

On 05/30/2016 07:56 PM, Daniel Lezcano wrote:

quoted

On 05/24/2016 03:15 PM, Shreyas B. Prabhu wrote:

quoted

+        psscr_val = kcalloc(dt_idle_states, sizeof(*psscr_val),
+                    GFP_KERNEL);
+        rc = of_property_read_u64_array(power_mgt,
+            "ibm,cpu-idle-state-psscr", psscr_val, dt_idle_states);

[cc'ed Lorenzo and Rob ]

I don't see the documentation for the binding. Wouldn't make sense to
add the value per idle state instead of an index based array ?

The binding *should* be documented here AFAIK:

  https://github.com/open-power/skiboot/blob/master/doc/device-tree/ibm%2Copal/power-mgt.txt

cheers