Thread (139 messages) 139 messages, 9 authors, 2016-11-24

Re: [PATCH V2 04/68] powerpc/mm: Use big endian page table for book3s 64

From: Aneesh Kumar K.V <hidden>
Date: 2016-05-30 14:48:30

Benjamin Herrenschmidt [off-list ref] writes:
On Mon, 2016-05-30 at 14:12 +0530, Aneesh Kumar K.V wrote:
quoted
=C2=A0/* Encode and de-code a swap entry */
@@ -516,10 +533,12 @@ static inline pte_t pte_swp_mksoft_dirty(pte_t
pte)
=C2=A0{
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return __pte(pte_val(pte=
) | _PAGE_SWP_SOFT_DIRTY);
quoted
=C2=A0}
These kind of setters (and mkspecial etc...) could also just OR
the byteswapped constant to the raw PTE..
We seems to be doing the right thing w.r.t setters


static inline pte_t pte_mkdirty(pte_t pte)
{
        return __pte(pte_val(pte) | _PAGE_DIRTY | _PAGE_SOFT_DIRTY);
     9d8:       ff ff 40 39     li      r10,-1
     9dc:       04 00 4a 79     rldicr  r10,r10,0,0
     9e0:       78 53 2a 7d     or      r10,r9,r10
}

-aneesh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help